Skip to content

Conversation

@binarycat0
Copy link
Contributor

fix: format/lint

@binarycat0
Copy link
Contributor Author

Introducing and applying prettier linter. @jbonofre please check when you have time 👋

@jbonofre jbonofre self-requested a review January 25, 2026 06:20
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
As lint is part of the Console CI, it makes sense to help contributors with lint process 😄

@jbonofre
Copy link
Member

@binarycat0 the CI is failing:

prettier: not found

The script has to be fixed.

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI.

@binarycat0
Copy link
Contributor Author

@jbonofre fix is merged. Should work well now. Need to rerun the CI check 🙏

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting changes are just formatting changes.
Cannot judge on the eslint/prettier settings, and I suspect that's largely going into personal preferences & opinions, so I'm okay with the style.

Would just be good if someone else could take a look into the config and build files.

@binarycat0
Copy link
Contributor Author

The formatting changes are just formatting changes. Cannot judge on the eslint/prettier settings, and I suspect that's largely going into personal preferences & opinions, so I'm okay with the style.

Would just be good if someone else could take a look into the config and build files.

Thanks for review. I agree that preferences are personal, and would be glad to get a comment from someone more experienced FE dev, because neither am I a professional FE dev 😄

@dimas-b
Copy link

dimas-b commented Jan 26, 2026

I'm fine with the new linter, but I do not work on UI code at all 😅

@adam-christian-software @vignesh-manel @developerzohaib786 @cccs-cat001 : WDYT?

@binarycat0
Copy link
Contributor Author

So, if there are no strong concerns, I think the current settings might be accepted and then corrected if needed.

Copy link
Contributor

@adam-christian-software adam-christian-software left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This will be wonderful in terms of standardization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants