-
Notifications
You must be signed in to change notification settings - Fork 111
chore: update release workflow to comply with Apache release practice #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: update release workflow to comply with Apache release practice #4128
Conversation
- Use downloads.apache.org/incubator/texera/KEYS as official KEYS URL - Remove 'rc' suffix from tarball filename (keep RC in directory name) - Simplify verification instructions (remove wget commands) - Add convenience binaries section to vote email template 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aglinxinyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| == Checklist for Reference == | ||
| Docker images (tag: ${VERSION}): | ||
| - https://hub.docker.com/r/apache/texera-workflow-compiling-service/tags?name=${VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- you can't publish docker images with the version until after the release vote passes
- you can publish with the version and rc number before the vote for review
- please read https://incubator.apache.org/guides/distribution.html#docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
| [ ] +1 Approve the release | ||
| [ ] 0 No opinion | ||
| [ ] -1 Disapprove the release (please provide the reason) | ||
| [ ] -1 Disapprove the release (please provide reason) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
Will the jars be pushed to repository.apache.org for review? |
Maybe we can discuss this in the release discussion email thread. I will initiate the thread soon. |
What changes were proposed in this PR?
Update release candidate workflow and vote email template based on Apache mentor feedback:
https://downloads.apache.org/incubator/texera/KEYS(official location, auto-synced from release)apache-texera-X.Y.Z-incubating-src.tar.gz). RC number remains in directory name.Any related issues, documentation, discussions?
Fixes #4127
How was this PR tested?
Template and workflow changes reviewed manually.
Was this PR authored or co-authored using generative AI tooling?
Co-authered with Claude Code (Claude Opus 4.5)