Skip to content

Added allow capital letter in dependency name #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turdusmerula wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added allow capital letter in dependency name #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyhelm3/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def __init__(self, _command: Command, **kwargs):


#: Type for a name (chart or release)
Name = constr(pattern = r"^[a-z0-9-]+$")
Name = constr(pattern = r"^[a-zA-Z0-9-]+$")
Copy link

@JohnGarbutt JohnGarbutt Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem we have is this type gets re-used in a few too many places. Its based on this documentation:
https://helm.sh/docs/chart_best_practices/conventions/#chart-names

I think we need to rework this one, potentially.



#: Type for a SemVer version
Expand Down