Added allow capital letter in dependency name#9
Open
turdusmerula wants to merge 1 commit intoazimuth-cloud:mainfrom
Open
Added allow capital letter in dependency name#9turdusmerula wants to merge 1 commit intoazimuth-cloud:mainfrom
turdusmerula wants to merge 1 commit intoazimuth-cloud:mainfrom
Conversation
|
I'm also seeing this with the policy-reporter helm chart and the |
JohnGarbutt
reviewed
Jun 23, 2025
|
|
||
| #: Type for a name (chart or release) | ||
| Name = constr(pattern = r"^[a-z0-9-]+$") | ||
| Name = constr(pattern = r"^[a-zA-Z0-9-]+$") |
There was a problem hiding this comment.
I think the problem we have is this type gets re-used in a few too many places. Its based on this documentation:
https://helm.sh/docs/chart_best_practices/conventions/#chart-names
I think we need to rework this one, potentially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am deploying the Authentik helm chart with pyhelm3 and I receive an error I think is not okay.
Inside the values.yaml file there is the following block:
The dependency name
serviceAccountdoes not validate with the ruler"^[a-z0-9-]+$"frommodels.py:42because it contains a capital letter.However the chart deploys perfectly fine with
helm3with no issue on the capital letter for the dependency name, I think the correct rule should ber"^[a-zA-Z0-9-]+$"which corrects the error I'm facing