-
-
Notifications
You must be signed in to change notification settings - Fork 645
build: Export runtime_env_toolchain_interpreter.sh file #3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hofbi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a build issue encountered when enabling the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly identifies the need to export runtime_env_toolchain_interpreter.sh to support the incompatible_no_implicit_file_export flag. However, the exports_files declaration is missing an explicit visibility, which means it defaults to private. This would prevent the file from being used by other packages, defeating the purpose of the change. I've recommended adding public visibility to ensure the file is accessible to all consumers of the toolchain.
|
|
||
| licenses(["notice"]) | ||
|
|
||
| exports_files(["runtime_env_toolchain_interpreter.sh"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exports_files declaration is missing a visibility attribute, so it defaults to private (//visibility:private). This means runtime_env_toolchain_interpreter.sh will only be accessible within the python/private package. However, since it's part of a toolchain used by other packages, it needs to be public. Please add visibility = ["//visibility:public"] to align with other exported toolchain files in this package, like python_bootstrap_template.txt.
| exports_files(["runtime_env_toolchain_interpreter.sh"]) | |
| exports_files(["runtime_env_toolchain_interpreter.sh"], visibility = ["//visibility:public"]) |
I am working on bazelbuild/bazel#27674 towards bazelbuild/bazel#10225 to flip
incompatible_no_implicit_file_export. I found that https://github.com/bazelbuild/bazel/blob/master/src/test/py/bazel/bzlmod/bazel_repo_mapping_test.py and https://github.com/bazelbuild/bazel/blob/master/src/test/py/bazel/bzlmod/bazel_module_test.py requireruntime_env_toolchain_interpreter.sh. Since it is no longer implicitly exported after flipping the flag, we have to export it explicitly.