Skip to content

build: Export runtime_env_toolchain_interpreter.sh file #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hofbi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Export runtime_env_toolchain_interpreter.sh file #3471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/private/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ package(

licenses(["notice"])

exports_files(["runtime_env_toolchain_interpreter.sh"])
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This exports_files declaration is missing a visibility attribute, so it defaults to private (//visibility:private). This means runtime_env_toolchain_interpreter.sh will only be accessible within the python/private package. However, since it's part of a toolchain used by other packages, it needs to be public. Please add visibility = ["//visibility:public"] to align with other exported toolchain files in this package, like python_bootstrap_template.txt.

Suggested change
exports_files(["runtime_env_toolchain_interpreter.sh"])
exports_files(["runtime_env_toolchain_interpreter.sh"], visibility = ["//visibility:public"])


filegroup(
name = "distribution",
srcs = glob(["**"]) + [
Expand Down