Skip to content

Conversation

@meawong
Copy link
Collaborator

@meawong meawong commented Dec 24, 2025

Issue #: /bcgov/entity#31756

Description of changes:

  • Use common _validate_postal_code method to apply conditional postal code logic (mirrors COD implementation for director mailing address validation)
  • Update/add unit tests

Before:
Validation was failing for a mailing address with no postal code for countries on the list (e.g. HK):
image

After:
Verify that postal code validation IS NOT enforced for countries on the list (e.g. HK):
image

Verify that postal code validation IS enforced for countries not on the list (e.g. CA):
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@meawong meawong self-assigned this Dec 24, 2025
@meawong meawong merged commit 6d807c3 into bcgov:main Dec 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants