Skip to content

31756 - Add no Postal Code Logic to AR #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meawong merged 2 commits into from
Dec 24, 2025
Merged

31756 - Add no Postal Code Logic to AR #3933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e8e89
31756 - Use common _validate_postal_code with NO_POSTAL_CODE_COUNTRY_…
meawong Dec 24, 2025
a83bfc2
31756 - Fix lint
meawong Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions legal-api/src/legal_api/services/filings/validations/annual_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

from legal_api.errors import Error
from legal_api.models import Address, Business
from legal_api.services.filings.validations.common_validations import _validate_postal_code
from legal_api.services.utils import get_date
from legal_api.utils.datetime import datetime

Expand Down Expand Up @@ -152,12 +153,11 @@ def validate_directors_addresses(annual_report: dict, legal_type: str) -> Option
msg = []
directors = annual_report["filing"]["annualReport"].get("directors", [])

# Required fields for mailingAddress
# Required fields for mailingAddress
mailing_required_fields = [
"streetAddress",
"addressCity",
"addressCountry",
"postalCode"
"addressCountry"
]

for idx, director in enumerate(directors):
Expand All @@ -177,6 +177,10 @@ def validate_directors_addresses(annual_report: dict, legal_type: str) -> Option
"path": f"/filing/annualReport/directors/{idx}/{address_type}/{field}"
})

postal_error = _validate_postal_code(address,f"/filing/annualReport/directors/{idx}/{address_type}")
if postal_error:
msg.append(postal_error)

if msg:
return Error(HTTPStatus.BAD_REQUEST, msg)

Expand Down
23 changes: 23 additions & 0 deletions legal-api/tests/unit/services/filings/validations/annual_report/test_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,29 @@ def test_validate(session, test_name, now, ar_date, agm_date,
}
]
),
(
"missing_mailingAddress_postalCode_required",
{"streetAddress": "123 A St", "addressCity": "Vancouver", "addressCountry": "CA", "postalCode": "V5K0A1"},
{"streetAddress": "123 A St", "addressCity": "Vancouver", "addressCountry": "CA", "postalCode": ""},
[
{
"error": "Postal code is required.",
"path": "/filing/annualReport/directors/0/mailingAddress/postalCode"
}
]
),
(
"SUCCESS_missing_mailingAddress_postalCode_not_required",
{"streetAddress": "123 A St", "addressCity": "Vancouver", "addressCountry": "CA", "postalCode": "V5K0A1"},
{"streetAddress": "123 A St", "addressCity": "Vancouver", "addressCountry": "HK", "postalCode": ""},
None
),
(
"SUCCESS_no_validation_on_postalCode_for_deliveryAddress",
{"streetAddress": "123 A St", "addressCity": "Vancouver", "addressCountry": "CA", "postalCode": ""},
{"streetAddress": "123 A St", "addressCity": "Vancouver", "addressCountry": "CA", "postalCode": "V5K0A1"},
None
),
(
"missing_mailing_address",
{"streetAddress": "123 A St", "addressCity": "Vancouver", "addressCountry": "CA", "postalCode": "V5K0A1"},
Expand Down
Loading