-
Notifications
You must be signed in to change notification settings - Fork 24
[PM-27232] Implement Registration for TDE Users #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 78.54% 78.85% +0.31%
==========================================
Files 283 283
Lines 29251 29625 +374
==========================================
+ Hits 22975 23362 +387
+ Misses 6276 6263 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7e40878 to
7fe5d69
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Overall Assessment: APPROVE Reviewed TDE registration implementation across registration.rs, crypto.rs, account_cryptographic_state.rs, and device_key.rs. The implementation is well-structured with comprehensive test coverage (97.8%) and follows established cryptographic patterns. See inline comments for details. |
|
Moving to draft until API bindings are updated. I believe all review so far has been addressed, and we should be close to good to go. |
|
…al into km/tde-registration




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27232
bitwarden/server#6671
📔 Objective
Implements registration for TDE users. This uses v2 encryption.
Note
The API changes here are not final and need an update to the automatic API bindings, after the corresponding server change is merged. This PR will only be merged once the binding changes are already in
mainand removed from this PR.🚨 Breaking Changes
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes