feat: add id support to patterns#5703
Merged
jmuzina merged 8 commits intocanonical:mainfrom Dec 4, 2025
Merged
Conversation
ee4c84a to
56e523a
Compare
Onibenjo
reviewed
Dec 1, 2025
jmuzina
reviewed
Dec 1, 2025
38eeaa6 to
258d38c
Compare
Contributor
Author
Onibenjo
reviewed
Dec 3, 2025
Contributor
Onibenjo
left a comment
There was a problem hiding this comment.
Some comments.
Also the QA steps needs updating from the old title id wording.
Aside these, LGTM.
jmuzina
reviewed
Dec 3, 2025
Onibenjo
approved these changes
Dec 3, 2025
Contributor
Onibenjo
left a comment
There was a problem hiding this comment.
Minor suggestion for consistency.
LGTM.
Contributor
|
@britneywwc can you fix the conflict. There's been a version bump on the main branch |
jmuzina
approved these changes
Dec 3, 2025
Member
jmuzina
left a comment
There was a problem hiding this comment.
A few small changes to get this ready for merge / release - I'll merge afterwards if all the checks are passing :)
5d19a64 to
c3300e2
Compare
c3300e2 to
5cf4723
Compare
Contributor
Author
|
Thanks again for the reviews! I'll leave the PR open until @jmuzina approves the pending checks :) |
jmuzina
approved these changes
Dec 4, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Done
Fixes WD-31488
QA
h2heading title under "Basic section / Mixed content" has an ID attached to itJinja Macrosectiontitle.iddocumentation has been updatedCheck if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]