Remove bumps and relocation-on-find from vecgeom tracker #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
bug
Test summary 5 847 files 9 385 suites 8m 31s ⏱️ For more details on these failures, see this check. Results for commit bc5149e. ♻️ This comment has been updated with latest results. |
This reverts commit b4ff3bb.
This reverts commit e89c24974f3b9b2a761374ae953b97210b6c5072.
This reverts commit fe5a539.
sethrj
force-pushed
the
vg-refactor-2
branch
from
e78256b to
eb79d72
Compare
…cision bvh All geo tests pass for vg 1.2.11, solids 2.0.0-rc7, surface 2.0.0-rc7, G4, ORANGE
This was broken before the last master merge
Member
Author
|
@esseivaju @mrguilima These are the changes I was talking about today. It looks like the missing piece was bumping greater than single-precision epsilon, which is what the vecgeom BVH requires. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #2131 .
This removes the "bumps" used in the different vecgeom navigators and adds error checking for finding valid distances and actually crossing boundaries. Now tracks that used to get stuck will fail gracefully. It makes the behavior of the different vecgeom versions much more consistent.
Follow-on work will add counters for how many tracks failed. I will also do performance testing before and after this changeset.