Add optical problem input and setup#2189
Merged
amandalund merged 6 commits intoceleritas-project:developfrom Jan 13, 2026
Merged
Add optical problem input and setup#2189amandalund merged 6 commits intoceleritas-project:developfrom
amandalund merged 6 commits intoceleritas-project:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2189 +/- ##
===========================================
- Coverage 86.15% 86.11% -0.04%
===========================================
Files 1287 1288 +1
Lines 40709 40810 +101
Branches 12994 12590 -404
===========================================
+ Hits 35074 35145 +71
+ Misses 4624 4472 -152
- Partials 1011 1193 +182
🚀 New features to boost your workflow:
|
Test summary 5 757 files 9 242 suites 17m 43s ⏱️ Results for commit ba8021c. ♻️ This comment has been updated with latest results. |
sethrj
approved these changes
Jan 12, 2026
Member
sethrj
left a comment
sethrj
left a comment
There was a problem hiding this comment.
Looks great! The OpticalProblem may warrant some refinement in the future but getting this in is a huge step in the right direction. Thanks!
(PS this will conflict with #2135 but since @Rashika-Gupta has been out I think we can work with her on merging that when she returns.)
amandalund
added
minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optical-only problem input and setup for cases where we only want to run the optical stepping loop in Celeritas. For now it's only used and tested in accel (when offloading optical distributions) but will be used standalone optical problems as well. I struggled a bit trying to figure out how best to set this up and could definitely use some feedback on how to improve it.