Simplify API, add new RedisClient and remove Factory#129
Merged
SimonFrings merged 1 commit intoclue:3.xfrom May 24, 2022
Merged
Simplify API, add new RedisClient and remove Factory#129SimonFrings merged 1 commit intoclue:3.xfrom
RedisClient and remove Factory#129SimonFrings merged 1 commit intoclue:3.xfrom
Conversation
SimonFrings
approved these changes
May 24, 2022
This was referenced Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset simplifies the API by adding a new
RedisClientand removing the existingFactory:Internally, the
RedisClientworks similar to what was previously called a "lazy" client, but we're getting rid of this wording altogether. This means it automatically creates the underlying connection to Redis only when it's actually needed and will close this connection after a short while when it is not in use anymore.A follow-up PR will update the "idle" or "keepalive" time and adjust the
openandcloseevent handling as discussed in #118.Builds on top of #128 and #87
Refs #118