Rename QueryResult to MysqlResult#187
Merged
clue merged 1 commit intofriends-of-reactphp:0.7.xfrom Nov 27, 2023
Merged
Conversation
WyriHaximus
approved these changes
Nov 25, 2023
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
While I think React\MySQL\Result would be better than React\MySQL\MysqlResult it's not a deal breaker for me. And I do agree with the argument that it makes low-level usage of this package easier. And honestly it's going tobe abstracted away by an ORM anywa.
clue
approved these changes
Nov 27, 2023
Contributor
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for looking into this.
I agree that either name is debatable, but including the Mysql prefix definitely helps to avoid some name clashes, so let's go ahead with this! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I propose changing the current
QueryResulttoMysqlResult. This change aligns with the recently introducedMysqlClientfrom #186, ensuring a consistent "Mysql" prefix throughout.The name "QueryResult" is not incorrect in this case. However, when working with multiple database clients in one project, it can lead to confusion about which specific "query result" is being referred to. For instance, the https://github.com/clue/reactphp-sqlite project has a similar class named
Result, which should also be renamed to something likeSqliteResultin the future.Furthermore, we applied a similar reasoning in reactphp/socket#263 and reactphp/http#417.
Refs #147
Builds on top of #186