Fix: Add debouncing to theme updates to prevent CPU spike#3590
Merged
ImprovedTube merged 1 commit intocode-charity:masterfrom Feb 3, 2026
Merged
Fix: Add debouncing to theme updates to prevent CPU spike#3590ImprovedTube merged 1 commit intocode-charity:masterfrom
ImprovedTube merged 1 commit intocode-charity:masterfrom
Conversation
Member
|
thank you! @AryaXDG would you also like to join us as a mentor for google summer of code if we are accepted? |
Contributor
Author
|
Hey! @ImprovedTube I am also looking forward to continuing my own active contributions to the project alongside guiding the students 😄 Here is my email for the official invite and next steps if we get accepted: aryadasgupta2004@gmail.com Let's do this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical performance issue where rapidly switching themes or using the color picker caused CPU usage to spike to 100% (Issue #3588).
Technical Details
The issue was caused by the extension triggering a full style recalculation and DOM repaint for every single input event. When a user rapidly clicked themes or dragged the color picker,
ImprovedTube.myColors()andImprovedTube.setTheme()were called dozens of times per second, overwhelming the browser's rendering engine.Changes:
js&css/web-accessible/core.jsfor thestorage-changedevent listener.setTimeout(200ms).Fixes
Fixes #3588