Adjust Logs #153
Open
Adjust Logs #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosammito
reviewed
Nov 11, 2025
nicosammito
requested changes
Dec 16, 2025
|
|
||
| message RuntimeErrorLog { | ||
| int64 node_id = 1; | ||
| string error = 2; |
Contributor
There was a problem hiding this comment.
Is this the error message or just a error type?
| message SuccessLog { | ||
| int64 node_id = 1; | ||
| shared.Value result = 2; | ||
| repeated shared.Value parameter = 3; |
Contributor
There was a problem hiding this comment.
Naming is a little bit confusing. Its not the parameter its the input value for each value
| } | ||
|
|
||
| message SuccessLog { | ||
| int64 node_id = 1; |
Contributor
There was a problem hiding this comment.
are you just using the index of the database id or also the complete id, because that its a string
Member
Author
There was a problem hiding this comment.
I'm using the database id that Sagittarius is giving me. In that case its an index
Taucher2003
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #152
The idea: instead of returning just application logs we can also log the result of evey node_function.
Instead of having just
Logwe would have:ApplicationLog=> Log from the ApplicationSuccessLog=> Result of a successful node_function executionRuntimeErrorLog=> Result of an unsuccessful node_function executionWhat do you think @Taucher2003 @nicosammito