Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,6 @@ services that Sagittarius must implement as a server.
├── flow_definition - Defines a definition for a Flow
├── runtime_function_definition - Defines types for runtime functions
├── struct - Defines types for json representations
└── translation - Contains translations with country codes and translated messages
├── translation - Contains translations with country codes and translated messages
└── version - Contains verion type for definitions
```
22 changes: 22 additions & 0 deletions proto/sagittarius/sagittarius.text_execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,28 @@ message TestExecutionResponse {
}

message Log {
oneof kind {
ApplicationLog application_log = 1;
SuccessLog success_log = 2;
RuntimeErrorLog error_log = 3;
}
}

message SuccessLog {
int64 node_id = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you just using the index of the database id or also the complete id, because that its a string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the database id that Sagittarius is giving me. In that case its an index

shared.Value result = 2;
repeated shared.Value parameter = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is a little bit confusing. Its not the parameter its the input value for each value

string timestamp = 4;
}

message RuntimeErrorLog {
int64 node_id = 1;
string error = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the error message or just a error type?

repeated shared.Value parameter = 3;
string timestamp = 4;
}

message ApplicationLog {
string message = 1;
string level = 2;
string timestamp = 3;
Expand Down