fix: Support custom --outputDir with code signing #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure custom outputDir always uses /CodePush subdirectory - Enable recursive directory creation for nested paths Fixes signature verification failures when using custom outputDir with privateKeyPath by maintaining correct ZIP structure that client SDK expects (CodePush/main.jsbundle).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using
--outputDirwith--privateKeyPathcauses signature verification failures on the client.Root Cause
The client SDK expects all files under a
CodePush/directory in the update ZIP. Custom outputDir paths like/tmp/CodePush-ios-49556resulted in files beingzipped as
CodePush-ios-49556/main.jsbundleinstead ofCodePush/main.jsbundle, breaking signature verification.Solution
/CodePushto custom outputDir paths to maintain correct ZIP structurerecursive: truewhen creating directories to support nested pathsThis is a general bug but it also enables features like parallel iOS/Android releases using different output directories while maintaining proper code signing.
Testing
--outputDir /tmp/CodePush-ios-12345 --privateKeyPath .codepush/private.pemoutputDorflagCodePush/main.jsbundlefor both default and custom outputDir