Skip to content

fix: Support custom --outputDir with code signing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerefel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Support custom --outputDir with code signing #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions script/command-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ function appRename(command: cli.IAppRenameCommand): Promise<void> {

export const createEmptyTempReleaseFolder = (folderPath: string) => {
return deleteFolder(folderPath).then(() => {
fs.mkdirSync(folderPath);
fs.mkdirSync(folderPath, { recursive: true });
});
};

Expand Down Expand Up @@ -1265,7 +1265,10 @@ export const release = (command: cli.IReleaseCommand): Promise<void> => {
export const releaseReact = (command: cli.IReleaseReactCommand): Promise<void> => {
let bundleName: string = command.bundleName;
let entryFile: string = command.entryFile;
const outputFolder: string = command.outputDir || path.join(os.tmpdir(), "CodePush");
let outputFolder: string = command.outputDir || path.join(os.tmpdir(), "CodePush");
if (command.outputDir && path.basename(outputFolder) !== "CodePush") {
outputFolder = path.join(outputFolder, "CodePush");
}
const platform: string = (command.platform = command.platform.toLowerCase());
const releaseCommand: cli.IReleaseCommand = <any>command;
// Check for app and deployment exist before releasing an update.
Expand Down