Run QA tools and fix issues

[f3l1x]

• Add native type hints for properties in RedisExtension24, RedisPanel, and RedisJournal
• Fix RedisJournal::write() PHPDoc to include optional expire key
• Add int cast to array index in RedisStorage::doMultiRead()
• Regenerate PHPStan baseline to reflect updated types

Summary by CodeRabbit

• Refactor
  • Improved type safety throughout the caching and dependency injection system with enhanced type declarations and annotations.
  • Fixed array index handling in Redis multi-read operations to ensure proper type consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The pull request adds strict type declarations to private properties across the Redis caching module, updates parameter documentation to reflect optional fields, applies integer type casting to array key access, and updates the PHPStan baseline configuration to reflect these type safety improvements.

Changes

Cohort / File(s)	Summary
Static Analysis Configuration phpstan-baseline.neon	Consolidated isset.offset errors for RedisJournal.php from separate entries into a single entry with count 2; updated contravariance message for RedisJournal::write to include optional fields (tags, priority, expire); added new ignoreError entry for RedisStorage.php offsetAccess.invalidOffset issue.
Property Type Declarations src/Caching/RedisJournal.php, src/DI/RedisExtension24.php, src/Tracy/RedisPanel.php	Added strict type annotations to private properties: ClientInterface type for $client in RedisJournal; array types for $defaults, $connectionDefaults, $sessionDefaults in RedisExtension24; array type for $connections in RedisPanel.
Parameter Documentation src/Caching/RedisJournal.php	Updated @param docblock for write method dependencies from array{tags: string[], priority: int} to array{tags?: string[], priority?: int, expire?: int}, marking fields as optional and adding expire key.
Array Key Type Casting src/Caching/RedisStorage.php	Cast array index to integer in doMultiRead method: changed $keys[$index] to $keys[(int) $index] for explicit type handling of array access.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Repetitive, mechanical type annotation additions following a consistent pattern across multiple files
• Single logic change in RedisStorage is straightforward (integer casting for array offset)
• Configuration updates in PHPStan baseline are consistent with the code changes

Poem

🐰 With whiskers twitched and types now clear,
The Redis paths grow strong, I cheer!
From untyped mist to safety's light,
Array keys cast, all feeling right.
Strong types bloom where chaos grew—
A safer cache, through and through! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check	❓ Inconclusive	The title 'Run QA tools and fix issues' is generic and does not clearly describe the specific changes made, such as adding type hints or fixing PHPDoc.	Consider a more specific title like 'Add native type hints and fix PHPDoc type declarations' to better reflect the primary changes in the changeset.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/run-qa-tools-01DhEfcZJ5dCRkerX55Btzg5

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8e2f32 and e9e2256.

📒 Files selected for processing (5)

• phpstan-baseline.neon (2 hunks)
• src/Caching/RedisJournal.php (2 hunks)
• src/Caching/RedisStorage.php (1 hunks)
• src/DI/RedisExtension24.php (1 hunks)
• src/Tracy/RedisPanel.php (1 hunks)

🔇 Additional comments (6)

src/Tracy/RedisPanel.php (1)

13-13: LGTM!

The addition of the array type declaration improves type safety while preserving the detailed shape in the docblock.

src/Caching/RedisStorage.php (1)

309-309: LGTM!

The explicit (int) cast ensures type safety when indexing into the $keys array. This defensive cast addresses PHPStan's concern about mixed array key types from the mget() iteration.

phpstan-baseline.neon (1)

24-24: LGTM!

The PHPStan baseline has been appropriately updated to reflect:

• The expanded parameter shape in RedisJournal::write() with optional expire field
• Current type safety state after property type declarations

Also applies to: 28-28, 141-145

src/DI/RedisExtension24.php (1)

23-28: LGTM!

The addition of array type declarations to these three properties improves type safety. The @var mixed[] docblocks appropriately document the mixed value types within the arrays.

Also applies to: 31-36, 39-41

src/Caching/RedisJournal.php (2)

21-21: LGTM!

The addition of the ClientInterface type declaration improves type safety for the $client property.

---

31-31: LGTM!

The updated docblock now accurately reflects the actual usage of the $dependencies parameter:

• All keys are optional (checked with isset in the method body)
• expire was previously undocumented but used at line 57

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}