Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,11 @@ parameters:
-
message: '#^Casting to int something that''s already int\.$#'
identifier: cast.useless
count: 1
path: src/Caching/RedisJournal.php

-
message: '#^Offset ''priority'' on array\{tags\: array\<string\>, priority\: int\} in isset\(\) always exists and is not nullable\.$#'
identifier: isset.offset
count: 1
path: src/Caching/RedisJournal.php

-
message: '#^Offset ''tags'' on array\{tags\: array\<string\>, priority\: int\} in isset\(\) always exists and is not nullable\.$#'
identifier: isset.offset
count: 1
count: 2
path: src/Caching/RedisJournal.php

-
message: '#^Parameter \#2 \$dependencies \(array\{tags\: array\<string\>, priority\: int\}\) of method Contributte\\Redis\\Caching\\RedisJournal\:\:write\(\) should be contravariant with parameter \$dependencies \(array\) of method Nette\\Caching\\Storages\\Journal\:\:write\(\)$#'
message: '#^Parameter \#2 \$dependencies \(array\{tags\?\: array\<string\>, priority\?\: int, expire\?\: int\}\) of method Contributte\\Redis\\Caching\\RedisJournal\:\:write\(\) should be contravariant with parameter \$dependencies \(array\) of method Nette\\Caching\\Storages\\Journal\:\:write\(\)$#'
identifier: method.childParameterType
count: 1
path: src/Caching/RedisJournal.php
Expand Down Expand Up @@ -150,6 +138,12 @@ parameters:
count: 1
path: src/Caching/RedisStorage.php

-
message: '#^Possibly invalid array key type mixed\.$#'
identifier: offsetAccess.invalidOffset
count: 1
path: src/Caching/RedisStorage.php

-
message: '#^Result of && is always false\.$#'
identifier: booleanAnd.alwaysFalse
Expand Down
5 changes: 2 additions & 3 deletions src/Caching/RedisJournal.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ final class RedisJournal implements Journal
public const SUFFIX_TAGS = 'tags';
public const SUFFIX_KEYS = 'keys';

/** @var ClientInterface $client */
private $client;
private ClientInterface $client;

public function __construct(ClientInterface $client)
{
Expand All @@ -29,7 +28,7 @@ public function __construct(ClientInterface $client)
/**
* Writes entry information into the journal.
*
* @param array{tags: string[], priority: int} $dependencies
* @param array{tags?: string[], priority?: int, expire?: int} $dependencies
*/
public function write(string $key, array $dependencies): void
{
Expand Down
2 changes: 1 addition & 1 deletion src/Caching/RedisStorage.php
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ private function doMultiRead(array $keys): array

$result = [];
foreach ($this->client->mget($formattedKeys) as $index => $stored) {
$key = $keys[$index];
$key = $keys[(int) $index];
$result[$key] = $stored ? self::processStoredValue($key, $stored) : null;
}

Expand Down
6 changes: 3 additions & 3 deletions src/DI/RedisExtension24.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,23 @@ final class RedisExtension24 extends CompilerExtension
{

/** @var mixed[] */
private $defaults = [
private array $defaults = [
'debug' => false,
'serializer' => null,
'connection' => [],
'clientFactory' => Client::class,
];

/** @var mixed[] */
private $connectionDefaults = [
private array $connectionDefaults = [
'uri' => 'tcp://127.0.0.1:6379',
'options' => [],
'storage' => false,
'sessions' => false,
];

/** @var mixed[] */
private $sessionDefaults = [
private array $sessionDefaults = [
'ttl' => null,
];

Expand Down
2 changes: 1 addition & 1 deletion src/Tracy/RedisPanel.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ final class RedisPanel implements IBarPanel
{

/** @var array<array{name: string, client: ClientInterface, uri: string|array<string>, options: array<mixed>}> */
private $connections;
private array $connections;

/**
* @param array<array{name: string, client: ClientInterface, uri: string|array<string>, options: array<mixed>}> $connections
Expand Down