Fix JSON schema #93
Merged
Fix JSON schema #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON schema was not valid because it referenced the unknown 'null' type. Add this to the list of built-in types so that a type definition will be generated.
Modify how we generate the JSON schema to respect that the canonical schema says that an optional attribute may be 'null'.
Remove some debugging output from the JSON schema builder. This was useful during testing, but it spams the build output, and shouldn't be needed now that the relevant functionality appears to be working.
ckyang0225
approved these changes
Jul 24, 2025
mwoehlke-kitware
approved these changes
Jul 24, 2025
Member
Author
|
If anyone wants to verify the updated JSON schema, it can be found in the CI archive (until that expires). |
Collaborator
|
I've verified the CI archive via https://www.jsonschemavalidator.net/, it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple issue with the generated JSON schema, one of which caused the schema itself to be invalid. Also, remove debugging output that shouldn't be needed.