Skip to content

Conversation

@jonasz-lasut
Copy link
Contributor

@jonasz-lasut jonasz-lasut commented Jan 17, 2026

Fixes #1003

Updated go get instruction for AWS Provider Go module and fixed import paths that were leading to function not compiling and not passing tests.

github.com/upbound/provider-aws/v2 import has to use at least version v2.3.0 as it's the first version with the correct module path

@netlify
Copy link

netlify bot commented Jan 17, 2026

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 51b9796
🔍 Latest deploy log https://app.netlify.com/projects/crossplane/deploys/696b869c9b8d7c0008fec50b
😎 Deploy Preview https://deploy-preview-1045--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Jonasz Łasut-Balcerzak <jonasz.lasut@gmail.com>
@jonasz-lasut jonasz-lasut force-pushed the 1003-go-function-docs branch from c956fdf to 51b9796 Compare January 17, 2026 12:54
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @jonasz-lasut!! it will be great to have this guide working again since moving to v2 😇

"k8s.io/utils/ptr"

"github.com/crossplane-contrib/provider-upjet-aws/apis/s3/v1beta1"
"github.com/upbound/provider-aws/v2/apis/namespaced/s3/v1beta1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah interesting, i was hoping that we'd still be able to use the github repo path (github.com/crossplane-contrib/provider-upjet-aws, not the module path (github.com/upbound/provider-aws), but that doesn't appear to be possible:

❯ go get github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0
go: downloading github.com/crossplane-contrib/provider-upjet-aws/v2 v2.3.0
go: github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0 requires go >= 1.24.10; switching to go1.24.12
go: github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0 requires github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0: parsing go.mod:
	module declares its path as: github.com/upbound/provider-aws/v2
	        but was required as: github.com/crossplane-contrib/provider-upjet-aws/v2

probably the same error you hit 😂

OK if we need to use the go module path, then that is reasonable!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly the same error 😅 We could handle that with go mod -replace ... but I didn't think it's worth to introduce that as it makes the guide less clear only for sake of keeping the crossplane-contrib in the module name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep agreed! and API groups / module names are permitted to stay as their original source before donation to crossplane-contrib as per governance, so all good!
https://github.com/crossplane/crossplane/blob/main/GOVERNANCE.md#policies-for-community-extension-projects

@jbw976 jbw976 merged commit 66b2d19 into crossplane:master Jan 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guide for writing function in go has issues with v2 updates

2 participants