Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions content/master/guides/write-a-composition-function-in-go.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/utils/ptr"

"github.com/crossplane-contrib/provider-upjet-aws/apis/s3/v1beta1"
"github.com/upbound/provider-aws/v2/apis/namespaced/s3/v1beta1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah interesting, i was hoping that we'd still be able to use the github repo path (github.com/crossplane-contrib/provider-upjet-aws, not the module path (github.com/upbound/provider-aws), but that doesn't appear to be possible:

❯ go get github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0
go: downloading github.com/crossplane-contrib/provider-upjet-aws/v2 v2.3.0
go: github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0 requires go >= 1.24.10; switching to go1.24.12
go: github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0 requires github.com/crossplane-contrib/provider-upjet-aws/v2@v2.3.0: parsing go.mod:
	module declares its path as: github.com/upbound/provider-aws/v2
	        but was required as: github.com/crossplane-contrib/provider-upjet-aws/v2

probably the same error you hit 😂

OK if we need to use the go module path, then that is reasonable!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly the same error 😅 We could handle that with go mod -replace ... but I didn't think it's worth to introduce that as it makes the guide less clear only for sake of keeping the crossplane-contrib in the module name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep agreed! and API groups / module names are permitted to stay as their original source before donation to crossplane-contrib as per governance, so all good!
https://github.com/crossplane/crossplane/blob/main/GOVERNANCE.md#policies-for-community-extension-projects


"github.com/crossplane/function-sdk-go/errors"
"github.com/crossplane/function-sdk-go/logging"
Expand Down Expand Up @@ -432,7 +432,7 @@ using the same strongly typed structs Crossplane uses in its providers.
You must get the AWS Provider Go module to use this type:

```shell
go get github.com/crossplane-contrib/provider-upjet-aws@v2.0.0
go get github.com/upbound/provider-aws/v2@v2.3.0
```

Crossplane provides a
Expand Down Expand Up @@ -475,7 +475,7 @@ import (
"google.golang.org/protobuf/testing/protocmp"
"google.golang.org/protobuf/types/known/durationpb"

"github.com/crossplane/crossplane-runtime/pkg/logging"
"github.com/crossplane/crossplane-runtime/v2/pkg/logging"

fnv1 "github.com/crossplane/function-sdk-go/proto/v1"
"github.com/crossplane/function-sdk-go/resource"
Expand Down
6 changes: 3 additions & 3 deletions content/v2.0/guides/write-a-composition-function-in-go.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/utils/ptr"

"github.com/crossplane-contrib/provider-upjet-aws/apis/s3/v1beta1"
"github.com/upbound/provider-aws/v2/apis/namespaced/s3/v1beta1"

"github.com/crossplane/function-sdk-go/errors"
"github.com/crossplane/function-sdk-go/logging"
Expand Down Expand Up @@ -432,7 +432,7 @@ using the same strongly typed structs Crossplane uses in its providers.
You must get the AWS Provider Go module to use this type:

```shell
go get github.com/crossplane-contrib/provider-upjet-aws@v2.0.0
go get github.com/upbound/provider-aws/v2@v2.3.0
```

Crossplane provides a
Expand Down Expand Up @@ -475,7 +475,7 @@ import (
"google.golang.org/protobuf/testing/protocmp"
"google.golang.org/protobuf/types/known/durationpb"

"github.com/crossplane/crossplane-runtime/pkg/logging"
"github.com/crossplane/crossplane-runtime/v2/pkg/logging"

fnv1 "github.com/crossplane/function-sdk-go/proto/v1"
"github.com/crossplane/function-sdk-go/resource"
Expand Down
6 changes: 3 additions & 3 deletions content/v2.1/guides/write-a-composition-function-in-go.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/utils/ptr"

"github.com/crossplane-contrib/provider-upjet-aws/apis/s3/v1beta1"
"github.com/upbound/provider-aws/v2/apis/namespaced/s3/v1beta1"

"github.com/crossplane/function-sdk-go/errors"
"github.com/crossplane/function-sdk-go/logging"
Expand Down Expand Up @@ -432,7 +432,7 @@ using the same strongly typed structs Crossplane uses in its providers.
You must get the AWS Provider Go module to use this type:

```shell
go get github.com/crossplane-contrib/provider-upjet-aws@v2.0.0
go get github.com/upbound/provider-aws/v2@v2.3.0
```

Crossplane provides a
Expand Down Expand Up @@ -475,7 +475,7 @@ import (
"google.golang.org/protobuf/testing/protocmp"
"google.golang.org/protobuf/types/known/durationpb"

"github.com/crossplane/crossplane-runtime/pkg/logging"
"github.com/crossplane/crossplane-runtime/v2/pkg/logging"

fnv1 "github.com/crossplane/function-sdk-go/proto/v1"
"github.com/crossplane/function-sdk-go/resource"
Expand Down