fix: clear up failed connection attempts

[xdustinface]

Not clearing them up restricts from repeated connection attempts.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of failed peer connections by ensuring problematic peers are immediately removed from the active pool, reducing unnecessary reconnection attempts and enhancing network stability.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes enhance peer pool management by ensuring failed peers are promptly removed from the connection pool following handshake or connection failures, and by clearing addresses from the connecting set when removing peers from the pool.

Changes

Cohort / File(s)	Summary
Peer Pool Cleanup dash-spv/src/network/manager.rs, dash-spv/src/network/pool.rs	Modified error handling in manager to remove failed peers from pool after connection/handshake failures. Updated remove_peer to also clear addresses from the connecting set, ensuring comprehensive peer cleanup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop, a skip, through network lanes,
We trim the failed ones from our chains,
Connecting sets now clean and bright,
Our pool of peers stays swift and right!
No lingering foes in memory's game—
Just honest peers with stellar fame! 🌟

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: clear up failed connection attempts' accurately summarizes the main changes: removing failed peers from the pool and clearing connecting addresses to allow retry attempts.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/clear-connection-attempts

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}