Skip to content

fix: clear up failed connection attempts #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xdustinface wants to merge 1 commit into
base: v0.42-dev
Choose a base branch
from
+4 −1
Open

fix: clear up failed connection attempts #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dash-spv/src/network/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ impl PeerNetworkManager {
}
Err(e) => {
log::warn!("Handshake failed with {}: {}", addr, e);
pool.remove_peer(&addr).await;
// Update reputation for handshake failure
reputation_manager
.update_reputation(
Expand All @@ -310,6 +311,7 @@ impl PeerNetworkManager {
}
Err(e) => {
log::debug!("Failed to connect to {}: {}", addr, e);
pool.remove_peer(&addr).await;
// Minor reputation penalty for connection failure
reputation_manager
.update_reputation(
Expand Down
3 changes: 2 additions & 1 deletion dash-spv/src/network/pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,9 @@ impl PeerPool {
Ok(())
}

/// Remove a peer from the pool
/// Remove a peer from the pool and clear connecting state
pub async fn remove_peer(&self, addr: &SocketAddr) -> Option<Arc<RwLock<Peer>>> {
self.connecting.write().await.remove(addr);
let removed = self.peers.write().await.remove(addr);
if removed.is_some() {
log::info!("Removed peer {}", addr);
Expand Down
Loading