Add macOS/Darwin build support and Clang compatibility fixes#2
Open
jzmiller1 wants to merge 1 commit intodavidson16807:masterfrom
Open
Add macOS/Darwin build support and Clang compatibility fixes#2jzmiller1 wants to merge 1 commit intodavidson16807:masterfrom
jzmiller1 wants to merge 1 commit intodavidson16807:masterfrom
Conversation
* Add Darwin/macOS platform detection and Homebrew paths to all 14 demo Makefiles * Add OpenMP support for macOS using libomp in 7-openmp and 8-interaction demos * Fix GLSL shader syntax errors (remove errant semicolons after main()) in 5 shader files * Remove constexpr from std::string return types in 10 analytic math headers (not literal type) * Replace std::vector<const std::string> with std::array in 3 index files (Clang compatibility) * Fix vexing parse issues in ColumnSummaryOps_test.cpp and CrustSummaryOps_test.cpp * Add initializer_list overload to PolynomialRailyardRelation.hpp for template deduction * Fix constexpr/static issues in Properties.hpp and GasPropertyStateRelation.hpp * Add missing includes and suppress Clang-specific warnings in test Makefiles
Author
|
Thanks for sharing your project. I did a bit to get the demos running on MacOS and thought I would share it as a PR in case you wanted any of these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Darwin/macOS platform detection and Homebrew paths to all 14 demo Makefiles
Add OpenMP support for macOS using libomp in 7-openmp and 8-interaction demos
Fix GLSL shader syntax errors (remove errant semicolons after main()) in 5 shader files
Remove constexpr from std::string return types in 10 analytic math headers (not literal type)
Replace std::vector with std::array in 3 index files (Clang compatibility)
Fix vexing parse issues in ColumnSummaryOps_test.cpp and CrustSummaryOps_test.cpp
Add initializer_list overload to PolynomialRailyardRelation.hpp for template deduction
Fix constexpr/static issues in Properties.hpp and GasPropertyStateRelation.hpp
Add missing includes and suppress Clang-specific warnings in test Makefiles
Comment out unused variables and type aliases to fix Clang -Wunused-* errors