fix(hook): Add missing hook_table_revert impl #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2024
willxinc
approved these changes
Feb 24, 2024
Collaborator
willxinc
left a comment
willxinc
left a comment
There was a problem hiding this comment.
Looks good to me, just a question about the failure case, as well as an overall question about when this would be used
| sym = &syms[j]; | ||
|
|
||
| if (hook_table_match_proc(&iate, sym)) { | ||
| // Only revert-able if the original pointer was stored previously |
Collaborator
There was a problem hiding this comment.
should we log in this case?
Contributor
Author
There was a problem hiding this comment.
We don't have logging available there. This is the capnhook package. =/
Apparently forgotten to get updated to reflect the currently supported versions correctly.
Contributor
Author
Added reasoning to commit body. |
Allow hooks to cleanup when they are shut down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(hook): Add missing hook_table_revert impl
Allow hooks to cleanup when they are shut down.
Stack created with Sapling. Best reviewed with ReviewStack.