Skip to content

Conversation

@icex2
Copy link
Contributor

@icex2 icex2 commented Feb 23, 2024

feat(dev): Add a separate docker dev container

Improve the development experience by providing
an additional docker container that can be started
and used as an interactive development environment.
It provides all the tools and a stable environment
for building (identical to the build container).


Stack created with Sapling. Best reviewed with ReviewStack.

Copy link
Collaborator

@willxinc willxinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to makefile are self contained, looks good to me

Oh also, the commit message has a spelling mistake

icex2 added 2 commits February 25, 2024 08:51
Apparently forgotten to get updated to reflect the
currently supported versions correctly.
Allow hooks to cleanup when they are shut down.
Improve the development experience by providing
an additional docker container that can be started
and used as an interactive development environment.
It provides all the tools and a stable environment
for building (identical to the build container).
@icex2 icex2 changed the title feat(dev): Add a separate docker dev cotainer feat(dev): Add a separate docker dev container Feb 25, 2024
@icex2 icex2 merged commit 6a98ce1 into master Feb 25, 2024
@icex2 icex2 deleted the pr287 branch February 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants