-
-
Notifications
You must be signed in to change notification settings - Fork 667
Disallow qualified types in base class list #16882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
thewilsonator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fix an issue? if so please retitle the commit message to fix it, otherwise please add a changelog entry.
afdc28b to
dd4d994
Compare
I filed one now. I hope it’s okay that I just put it in the most recent commit message. |
218c7a2 to
beb9eec
Compare
beb9eec to
47e1c7e
Compare
|
The CircleCI fails due to the (I guess usual) |
Timeout |
I realized a merge was needed anyways. Generally speaking, if a timeout is the reason it failed, should I do a force push to re-do the tests? |
Currently, it is allowed that a base class is a qualified type.
The qualifier is ignored. For that reason, this change makes it a parse error, so no code fools a reader into thinking the
constdoes something. Semantics are unaffected, i.e. if atypeoftype is used which ends up being a qualified class type, the unqualified version of that class type remains a base class (no error).The assumption of this PR is that no-one actually has qualified base classes in their code base (because the qualifier does nothing but mislead the reader).
It is in the interest of the Primary Type Syntax DIP and possibly future tuple DIPs to avoid parsing ambiguities. This can be done by requiring the base class list to be lexically comprised of new-terminology basic types. Refer to the accompanying spec PR for details.