-
Notifications
You must be signed in to change notification settings - Fork 269
feat(ros-compat): add minimal ROS message conversion with Python example #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ros-compat): add minimal ROS message conversion with Python example #1285
Conversation
63682b1 to
80ef9d6
Compare
|
Hi @haixuanTao, Thanks for the feedback. I have simplified the PR significantly based on your suggestions. |
|
I think one of the main limitation of this implementation is that it doesn't automatically generate message format as the ros2 api and also it is only available in Python |
…OS python path resolution
a2a762d to
d239f40
Compare
|
I have added |
|
Can you add an example in the ci that makes a ros1 node talk to a dora node? Like for example the turtle bot example for ros2? |
|
The CI example does not use dora dataflow |
0f9f433 to
37661b0
Compare
…y import, and Windows encoding
37661b0 to
8088129
Compare
|
I have updated the CI to run the full dora dataflow (dora start examples/ros-compat/python/ros1_turtle/dataflow.yml) instead of just the unit test. The bridge node now supports a mock mode to allow this full dataflow execution to pass in the CI environment without a running ROS master. |
#1231
This PR adds a minimal Python API for converting Dora Arrow arrays to ROS message format dictionaries. Sometimes you need to work with ROS message structures in Dora nodes without setting up a full ROS bridge, and this library makes that easy.
Right now it only supports
geometry_msgs/Twist, but the structure is simple enough that we can easily add more message types later.dora-ros-compatwith a simpleRosMessageConverterclassfrom dora.ros import RosMessageConverter- converts Arrow arrays to ROS message dicts