Open
Conversation
This is in preparation to some gibs improvements.
In the original game, all gibs start flying from one single point (i.e. `playerOrigin`), which is sometimes noticeable. Let's position the gibs closer to where they are supposed to be anatomically. That is, legs go lower, head goes higher.
ffbc161 to
ca4a10c
Compare
The previous commit added proper initial positions to each individual gib. And now it's time to also make sure that they're facing the right direction.
ca4a10c to
094661f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original game, all gibs start flying from one single point
(i.e.
playerOrigin), which is sometimes noticeable.Let's position the gibs closer to where they are supposed to be
anatomically. That is, legs go lower, head goes higher.
Note that bots seem to have their
lerpAngleswrong, which is also evident by where bots' dead bodies face when they die. But for regular players this works well.Here is the Ranger's box, which I took for reference:

Screenshots
This is how it used to be before:

How this MR makes it:
This is mostly a preparation for the rewrite of #51, for which it is nice to have properly positioned gibs.