Skip to content

Fix/charshape constraint edge#27

Merged
mathleur merged 2 commits intoecmwf:mainfrom
NiallOswald:fix/charshape-constraint-edge
Oct 14, 2025
Merged

Fix/charshape constraint edge#27
mathleur merged 2 commits intoecmwf:mainfrom
NiallOswald:fix/charshape-constraint-edge

Conversation

@NiallOswald
Copy link
Contributor

Description

  • Add missing constraint edge in charshape.
  • Simplify boundary edge detection.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@NiallOswald NiallOswald marked this pull request as ready for review October 13, 2025 16:54
@mathleur mathleur self-requested a review October 14, 2025 08:41
@mathleur mathleur merged commit 30242f3 into ecmwf:main Oct 14, 2025
4 checks passed
mathleur pushed a commit that referenced this pull request Oct 20, 2025
* fix: simplify boundary edge checks

* fix: add missing constraint edge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants