Skip to content

Fix/charshape constraint edge #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathleur merged 2 commits into from
Oct 14, 2025
Merged

Fix/charshape constraint edge #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83dc25
fix: simplify boundary edge checks
NiallOswald Oct 13, 2025
68bd19b
fix: add missing constraint edge
NiallOswald Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/algorithms/simplify_charshape.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,27 +92,27 @@ fn characteristic_shape<T>(orig: &Polygon<T>, eps: T, max_len: usize) -> Polygon
where
T: GeoFloat + SpadeNum,
{
let orig_len = orig.exterior().0.len();

if orig_len < 3 {
if orig.exterior().0.len() < 3 {
return orig.clone();
}

let eps_2 = eps * eps;

// Construct Delaunay triangulation
let num_vertices = orig.exterior().0.len() - 1;

let vertices = orig
.exterior_coords_iter()
.take(orig_len - 1) // duplicate points are removed
.take(num_vertices) // duplicate points are removed
.map(|c| Point2::new(c.x, c.y))
.collect::<Vec<_>>();

let edges = (0..orig_len - 2)
let edges = (0..num_vertices)
.map(|i| {
if i == 0 {
[vertices.len() - 1, i]
} else {
[i, i + 1]
[i - 1, i]
}
})
.collect::<Vec<_>>();
Expand Down Expand Up @@ -143,8 +143,7 @@ where
continue;
}

let [from, to] = largest.edge.vertices().map(|v| v.index());
if (to == from + 1) || (from == to + 1) || (to + from + 2 == orig_len) {
if largest.edge.is_constraint_edge() {
continue;
}

Expand Down