fix: define both prefer and requires for packages:all
#48
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug where packages with specified versions were not inheriting overall requirements from packages:all:require. The solution adds a parallel packages:all:prefer section that applies preferences in a non-overridable way, ensuring that even packages with specific version requirements still pick up the desired compiler, build type, and other preferences.
Key changes:
- Added
prefersection topackages:allwith gcc compiler, IPO, cmake build system, and Release build type - Retained existing
requiresection withany_ofpatterns for flexibility - Changed dd4hep compiler requirement from
%gccto%clangto match ACTS requirements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
packages-all-prefer-require
branch
from
802a3d0 to
fb3c06c
Compare
wdconinc
force-pushed
the
packages-all-prefer-require
branch
from
fb3c06c to
c5483e9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
packages-all-prefer-require
branch
from
19b3c0a to
48fa716
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
packages-all-prefer-require
branch
from
447bd55 to
8d6c702
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Clarify comments regarding the prefer and require sections in packages.yaml.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated dependencies and requirements for ACTS and dd4hep in packages.yaml.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Briefly, what does this PR introduce?
We currently use
packages: all: requirefor setting overall preferences like compiler, cmake build type, etc. This is overridden by individual package requirements such as version. In order to have the overridden packages also pick up the desired requirements, we also add them as preferences withpackage: all: preferwhich is not overridden (but not required...).Since this affects the environment solutions, some packages have received additional version hints or explicit variant specifications that were previously satisfied implicitly.
Also:
What kind of change does this PR introduce?