(fix): Add support for +required marker #192
Conversation
The +required marker is now recognized and produces the same
"Required: {}" output as +kubebuilder:validation:Required.
Assisted-by: CLAUDE
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
|
Hi @tenstad @thbkrkr @charith-elastic @barkbay @zirain I am not sure if I can sign your CLA. For optional // +optional you probably need to ensure the same. Please, feel free to get the code and and open a PR by yourselves. |
|
We probably also want to consider implementing support for the Declarative validation style markers ( |
|
Thanks! Closing this in favor of #193 that builds on this work and adds support for the required/optional Kubernetes markers. |
…#193) This adds support for the +required, +k8s:required, +optional and +k8s:optional markers, aligning with upstream Kubernetes marker conventions. Additionally, it improves the escaping of pipe character for validation value in Asciidoctor output to prevent formatting issues. Based on the work from #192, with additional changes.
…elastic#193) This adds support for the +required, +k8s:required, +optional and +k8s:optional markers, aligning with upstream Kubernetes marker conventions. Additionally, it improves the escaping of pipe character for validation value in Asciidoctor output to prevent formatting issues. Based on the work from elastic#192, with additional changes.
3 participants
Description
The +required marker is now recognized and produces the same "Required: {}" output as +kubebuilder:validation:Required.
Motivation
// +requiredis a valid marker and should be recognised such as+kubebuilder:validation:RequiredAlso, see the issue: kubernetes-sigs/controller-tools#1241
The project will deprecate the
+kubebuilder:validation:Requiredin favor of// +required