Support +required, +k8s:required, +optional and +k8s:optional markers #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
thbkrkr
changed the title
The +required marker is now recognized and produces the same
"Required: {}" output as +kubebuilder:validation:Required.
Assisted-by: CLAUDE
thbkrkr
force-pushed
the
support-more-markers
branch
from
3c23d41 to
88bbe30
Compare
zirain
approved these changes
Jan 6, 2026
pebrc
approved these changes
Jan 7, 2026
simonrw
pushed a commit
to simonrw/crd-ref-docs
that referenced
this pull request
Jan 8, 2026
…elastic#193) This adds support for the +required, +k8s:required, +optional and +k8s:optional markers, aligning with upstream Kubernetes marker conventions. Additionally, it improves the escaping of pipe character for validation value in Asciidoctor output to prevent formatting issues. Based on the work from elastic#192, with additional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
+required,+k8s:required,+optionaland+k8s:optionalmarkers, aligning with upstream Kubernetes marker conventions.Additionally, it improves the escaping of pipe character for validation value in Asciidoctor output to prevent formatting issues.
Based on the work from #192, with additional changes.