Increase minimum height; remove unnecessary scrolled window #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The scrolled window was added in #178 to fix several user-reported issues. It looks like this especially effects users with very low laptop resolutions. So, I'm inclined to close this as design conflict |
danirabbit
added
the
Design Conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the minimum size of the Switchboard so that most plug windows do not require scrolling to access all the settings.
There seems little purpose in being able to resize the Switchboard to smaller than its natural size as it is only used occasionally.
Unfortunately, Switchboard does not know the natural sizes of all the plugs and its natural size is slightly too small for some plugs, so an explicit size request is used.
This change also addresses difficulty scrolling some plug windows e.g. elementary/settings-desktop#299.