Stack Switcher → SettingsSidebar #299
Conversation
danirabbit
changed the title
|
Something about this layout seems off, maybe it's that the current one is more natural to read (I think because it's above the page and horizontally laid out) |
# Conflicts fixed in: # src/Views/Multitasking.vala
|
@danrabbit I have fixed conflicts with master. One problem I have noticed with using Granite.SimpleSettingsPage (a scrolled window) with Multi-tasking View is that if the window height is such as to require scrolling then if you scroll on the content area you will at some point enter a combo and start changing the options instead of scrolling - which is definitely undesirable. The simplest solution is to set a minimum height on the Settings window sufficient that scrolling is never required on Multitasking View. |
|
I have proposed a change to Switchboard (elementary/settings#242) so that this view does not have to scroll and all the settings are visible when it is opened. |
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
The code looks good and the change makes sense in the context of a strategy of moving all the plugs using a Stack to a SettingsSidebar (as many are already).
The screenshots need updating.
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
I get warnings when I close the System Settings app in this branch:
** (io.elementary.switchboard:4237): CRITICAL **: 20:14:27.643: granite_settings_sidebar_row_get_page: assertion 'self != NULL' failed
(io.elementary.switchboard:4237): Gtk-CRITICAL **: 20:14:27.643: gtk_stack_set_visible_child: assertion 'GTK_IS_WIDGET (child)' failed
Overall I think this is a step in a good direction but it needs more polishing. For example:
- 'Wallpaper' and 'Dock & Panel' pages shouldn't use the same icon;
- Appearance tab looks weird compared to other pages because of it's long description while other pages don't have it at all;
- IMO It would be nice if every page's max width was the same and these header labels wouldn't jump around
| if (((GLib.DBusProxy) pantheon_act).get_cached_property ("PrefersColorScheme") != null) { | ||
| grid.attach (dark_label, 0, 0, 2); | ||
| grid.attach (dark_info, 0, 1, 2); | ||
| grid.attach (prefer_style_box, 0, 2, 2); |
There was a problem hiding this comment.
This grid's attaches should start with 0, 0, not from 0, 2 straightaway.
No description provided.