Skip to content

Comments

Add example automation config#7

Open
adamhutchings wants to merge 2 commits intoepic-open-source:mainfrom
adamhutchings:add-auto-config
Open

Add example automation config#7
adamhutchings wants to merge 2 commits intoepic-open-source:mainfrom
adamhutchings:add-auto-config

Conversation

@adamhutchings
Copy link

No description provided.

Copy link
Contributor

@gbowlin gbowlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks, simple changes to reduce config bloat.

Comment on lines +3 to +7
A1C:
- '>7'
- '>8'
- None
- Norm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A1C:
- '>7'
- '>8'
- None
- Norm

Lets keep this limited to the "most important" groups.

Comment on lines +24 to +33
Taking Insulin:
- Down
- 'No'
- Steady
- Up
Taking Metformin:
- Down
- 'No'
- Steady
- Up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Taking Insulin:
- Down
- 'No'
- Steady
- Up
Taking Metformin:
- Down
- 'No'
- Steady
- Up

same removing non age-race-gender columns

Comment on lines 14 to 15
automation_config: "automation.yml"
log:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
automation_config: "automation.yml"
log:
automation_config: "automation.yml"
# log metrics to a file
log:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants