chore: fixed type errors in xgboost.py #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the way bin edges are passed to
pd.cutin thexgboost.pymodule. The change ensures compatibility by converting numpy arrays of bin edges to Python lists before passing them topd.cut.xgboost_histogrammify_with_handxgboost_histogrammify_with_x_bin_edges, bin edge arrays are now converted to lists using.tolist()before being used as thebinsparameter inpd.cut. [1] [2]