Skip to content

chore: fixed type errors in xgboost.py #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eschmidt42 merged 1 commit into from
Aug 16, 2025
Merged

chore: fixed type errors in xgboost.py #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/random_tree_models/xgboost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def xgboost_histogrammify_with_h(

rank_bin_edges = np.histogram_bin_edges(rank, bins=n_bins)
bin_assignments = pd.cut(
rank, bins=rank_bin_edges, labels=False, include_lowest=True
rank, bins=rank_bin_edges.tolist(), labels=False, include_lowest=True
)

x_bin_edges = np.interp(rank_bin_edges, rank, x_ordered)
Expand All @@ -126,7 +126,7 @@ def xgboost_histogrammify_with_x_bin_edges(

for i in range(X.shape[1]):
bin_assignments = pd.cut(
X[:, i], bins=all_x_bin_edges[i], labels=False, include_lowest=True
X[:, i], bins=all_x_bin_edges[i].tolist(), labels=False, include_lowest=True
)

X_hist[:, i] = bin_assignments
Expand Down
Loading