Skip to content

common/prque: eliminate redundant type assertion in sstack.Push #33470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0xlupin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

common/prque: eliminate redundant type assertion in sstack.Push #33470

0xlupin wants to merge 2 commits into from
+3 −2

Conversation

@0xlupin
Copy link

@0xlupin 0xlupin commented Dec 21, 2025

This PR removes a redundant type assertion in the sstack.Push method.

jrhea
jrhea reviewed Dec 22, 2025
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix seems okay to me in theory, but item := data.(*item[P,V]) shadows the item type. Renaming the new local item variable to something else should fix it.

@0xlupin
Copy link
Author

0xlupin commented Dec 22, 2025

The fix seems okay to me in theory, but item := data.(*item[P,V]) shadows the item type. Renaming the new local item variable to something else should fix it.

all done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrhea jrhea jrhea left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xlupin @jrhea