Skip to content

common/prque: eliminate redundant type assertion in sstack.Push #33470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xlupin wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

common/prque: eliminate redundant type assertion in sstack.Push #33470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20dfef2
Update sstack.go
0xlupin Dec 21, 2025
ab9901b
Update sstack.go
0xlupin Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions common/prque/sstack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func newSstack[P cmp.Ordered, V any](setIndex SetIndexCallback[V]) *sstack[P, V]
// Push a value onto the stack, expanding it if necessary. Required by
// heap.Interface.
func (s *sstack[P, V]) Push(data any) {
itm := data.(*item[P, V])
if s.size == s.capacity {
s.active = make([]*item[P, V], blockSize)
s.blocks = append(s.blocks, s.active)
Expand All @@ -62,9 +63,9 @@ func (s *sstack[P, V]) Push(data any) {
s.offset = 0
}
if s.setIndex != nil {
s.setIndex(data.(*item[P, V]).value, s.size)
s.setIndex(itm.value, s.size)
}
s.active[s.offset] = data.(*item[P, V])
s.active[s.offset] = itm
s.offset++
s.size++
}
Expand Down