Fix build on cuda 12.5 #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
zynabazizi
referenced
this pull request
Oct 19, 2025
fbshipit-source-id: 1a7f42186221c0f3c5c109d886ca6b55e6348897
Contributor
|
The GpuANSEncode.cuh change was made in a different way in e1ea8bd to ensure backwards compatibility can you remove your version of that change and re-submit? |
Author
|
👍 |
Author
|
@wickedfoo I just re-submit the PR as #26 . thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes build on CUDA version 12.6 and includes two modifications;
__thrust_exec_check_disable__to_CCCL_EXEC_CHECK_DISABLE.