Fix build on CUDA 12.6 and Pytorch >= 2.1 #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a re-submission of #22
The issue of
__thrust_exec_check_disable__macroOn my environment with CUDA 12.6, build is still broken after the change e1ea8bd .
Although I'm not sure about when
__thrust_exec_check_disable__was removed, butI checked the NVIDIA's official Docker image and confirmed that it was already removed at 12.6.
__thrust_exec_check_disable__is not found._CCCL_EXEC_CHECK_DISABLEis found.So, it would be more robust to check the existence of
_CCCL_EXEC_CHECK_DISABLEand__thrust_exec_check_disable__withifdef.C++17
In addition, recent Pytorch versions require C++17 and I think it's safe to migrate the entire dietgpu project to C++17.