Skip to content

Implement button to copy output to clipboard#5

Closed
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
lukasaldersley:miscFixes
Closed

Implement button to copy output to clipboard#5
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
lukasaldersley:miscFixes

Conversation

@lukasaldersley
Copy link
Contributor

@lukasaldersley lukasaldersley commented Jun 6, 2025

  • Implemented Copy-To-Clipboard using the clipboard API (only available on https sites or localhost)
  • fixed incorrect id (exportOption2 vs listOption)
  • fixed typo 'ouput' to 'output'
  • changed var to let to harden against accidental scope leaks

(this is independent of #4 or #6 and neither requires the other. If you want me to rebase this onto either #4 or #6 instead of merging this, I'd be happy to do so)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements a copy-to-clipboard feature for the markdown output, addressing several minor bugs and code quality improvements along the way.

  • Adds a new copy button using the clipboard API for copying output to clipboard
  • Fixes HTML element ID mismatches and typos in element names
  • Updates variable declarations from var to let for better scoping

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
script.js Adds copyExport function, fixes variable declarations, corrects element ID references
index.html Adds copy button, fixes label-input ID mismatch, corrects typos in element IDs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@farnots
Copy link
Owner

farnots commented Aug 28, 2025

Thanks for your PR @lukasaldersley. I made changes on #8 and merge it. Sorry for the duplicate

@farnots farnots closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants