Implement button to copy output to clipboard#5
Closed
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
Closed
Implement button to copy output to clipboard#5lukasaldersley wants to merge 2 commits intofarnots:masterfrom
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a copy-to-clipboard feature for the markdown output, addressing several minor bugs and code quality improvements along the way.
- Adds a new copy button using the clipboard API for copying output to clipboard
- Fixes HTML element ID mismatches and typos in element names
- Updates variable declarations from
vartoletfor better scoping
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| script.js | Adds copyExport function, fixes variable declarations, corrects element ID references |
| index.html | Adds copy button, fixes label-input ID mismatch, corrects typos in element IDs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
|
Thanks for your PR @lukasaldersley. I made changes on #8 and merge it. Sorry for the duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this is independent of #4 or #6 and neither requires the other. If you want me to rebase this onto either #4 or #6 instead of merging this, I'd be happy to do so)