Implement additional output format for comments#6
Open
lukasaldersley wants to merge 4 commits intofarnots:masterfrom
Open
Implement additional output format for comments#6lukasaldersley wants to merge 4 commits intofarnots:masterfrom
lukasaldersley wants to merge 4 commits intofarnots:masterfrom
Conversation
This was referenced Jun 6, 2025
As reddit will only return up to 10 nested levels of comments in their json API, any comment beyond that must be loaded in a seperate call
lukasaldersley
force-pushed
the
blockquote
branch
from
acb6706 to
f035f0b
Compare
Contributor
Author
|
rebased to current master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented a cleaner way to display comments in markdown using nested blockquotes.
This PR relies on #4 (in sofar as it incorporates the commits present there) as the differentiation between deleted comments and those simply nested too deeply is relevant for formatting the output.
If you'd be open to merging this I'd recommed just closing #4 and merging this here instead [though even if you do that, I'd still be glad if you could still consider my remarks on license and editorconfig I made in #4].
#5 is still completely independent from this.