Implement loading comments beyond depth limit#4
Open
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
Open
Implement loading comments beyond depth limit#4lukasaldersley wants to merge 2 commits intofarnots:masterfrom
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
Conversation
This was referenced Jun 6, 2025
Contributor
Author
As reddit will only return up to 10 nested levels of comments in their json API, any comment beyond that must be loaded in a seperate call
Contributor
Author
|
rebase to current master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reddit will only return up to 10 nested levels of comments in their json API, any comment beyond that must be loaded in a seperate call.
Previously any comment beyond the depth limit would simply have been reported as "deleted".
This adds the option to load those comments individually should the need arise.
I would further suggest you add an editorconfig file (it has been a bit of a fight with my editor to not constantly apply my default formatting to your project) and a license.