Skip to content

Implement loading comments beyond depth limit#4

Open
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
lukasaldersley:master
Open

Implement loading comments beyond depth limit#4
lukasaldersley wants to merge 2 commits intofarnots:masterfrom
lukasaldersley:master

Conversation

@lukasaldersley
Copy link
Contributor

As reddit will only return up to 10 nested levels of comments in their json API, any comment beyond that must be loaded in a seperate call.

Previously any comment beyond the depth limit would simply have been reported as "deleted".
This adds the option to load those comments individually should the need arise.

I would further suggest you add an editorconfig file (it has been a bit of a fight with my editor to not constantly apply my default formatting to your project) and a license.

@lukasaldersley
Copy link
Contributor Author

If you'd be open to merge #6 at all, please merge that instead and simply close this here as #6 depends on the changes made here enough that #6 contains the same commits.

As reddit will only return up to 10 nested levels of comments in their json API, any comment beyond that must be loaded in a seperate call
@lukasaldersley
Copy link
Contributor Author

rebase to current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant