Open
Conversation
Zane-122
requested changes
Feb 21, 2026
Contributor
Zane-122
left a comment
Zane-122
left a comment
There was a problem hiding this comment.
Also make sure that everything that needs to be implemented form cannon that is in the button bindings diagram is implemented
| // TODO: Bind SmartClimb to Y, and bind manual climb to Joystick | ||
|
|
||
| // new Trigger(driver::getBButton).onTrue(turret.aimWithTarget(drivetrain, FieldConstants.getTargetData(FieldConstants.GOAL_POSITION))); | ||
| // new Trigger(driver::getBButton).onTrue(turret.aimWithTarget(drivetrain, FieldConstants.getTargetData(FieldConstants.GOAL_POSITION))); |
Contributor
There was a problem hiding this comment.
Do what these were doing before with cannon... they can't stay commen ted out. It would just be like cannon.turretAim() or soemthing.
| .andThen(indexer.indexCommand(IndexerConstants.SPINDEXDER_POWER, IndexerConstants.TRANSFER_POWER)) | ||
| .finallyDo(shooter::stop)); | ||
|
|
||
| // new Trigger(copilot::getBButton).whileTrue(turret.aimWithTarget(drivetrain, FieldConstants.getTargetData(FieldConstants.GOAL_POSITION))); |
| new Trigger(() -> copilot.getRightTriggerAxis() > DriveConstants.TRIGGER_DEADBAND).whileTrue( | ||
| collector.pivotCommand(CollectorConstants.DEPLOY_ANGLE)); | ||
|
|
||
| new Trigger(() -> copilot.getRightTriggerAxis() > DriveConstants.TRIGGER_DEADBAND) |
Contributor
There was a problem hiding this comment.
there are already default commands for this, we don't need this
Zane-122
requested changes
Feb 21, 2026
Contributor
Zane-122
left a comment
Zane-122
left a comment
There was a problem hiding this comment.
Add any other bindings that are not currently implemented like hood down as x... even if they are not currently in robot container they have to be implemented in here.
|
|
||
| // new Trigger(driver::getBButton).onTrue(turret.aimWithTarget(drivetrain, FieldConstants.getTargetData(FieldConstants.GOAL_POSITION))); | ||
| // new Trigger(driver::getBButton).onTrue(turret.aimWithTarget(drivetrain, FieldConstants.getTargetData(FieldConstants.GOAL_POSITION))); | ||
| new Trigger(() -> copilot.getBButton()).whileTrue(cannon.turretAim(FieldConstants.GOAL_POSITION)); |
Contributor
There was a problem hiding this comment.
This should be a default command... make this smart shot
|
|
||
| new Trigger(() -> copilot.getRightTriggerAxis() > DriveConstants.TRIGGER_DEADBAND).whileTrue( | ||
| collector.pivotCommand(CollectorConstants.DEPLOY_ANGLE)); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.